Add project path to app Kernel instanciation #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
I totally forgot this entrypoint... (though I'm also removing the |
|
To me: 3.3 |
nicolas-grekas
approved these changes
Mar 23, 2019
fabpot
approved these changes
Mar 24, 2019
ghost
pushed a commit
that referenced
this pull request
Mar 24, 2019
stof
reviewed
Mar 27, 2019
| @@ -33,6 +33,6 @@ if ($_SERVER['APP_DEBUG']) { | |||
| } | |||
| } | |||
|
|
|||
| $kernel = new Kernel($_SERVER['APP_ENV'], (bool) $_SERVER['APP_DEBUG']); | |||
| $kernel = new Kernel($_SERVER['APP_ENV'], (bool) $_SERVER['APP_DEBUG'], dirname(__DIR__)); | |||
There was a problem hiding this comment.
shouldn't it be part of a 4.3+ recipe only instead ?
There was a problem hiding this comment.
Same for the other entrypoint then (public/index.php) I guess.
To me: 3.3
That's been done acting on @nicolas-grekas's recommendation above. I'll let him give his own rationale 👍
There was a problem hiding this comment.
Duplicating all the files in the recipe is not worth it.
|
reverted |
fabpot
added a commit
that referenced
this pull request
Mar 29, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed invocation of the Kernel according to the feature from symfony/symfony#30651.
This removes the need for a
composer.jsonto define the project folder when using the framework bundle.