Allow changing environement when .env.local.php exists.
#647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
This prevents surprises when you have generated the file, and then run your tests.
fabpot
approved these changes
Nov 17, 2019
|
this PR assumes we do this in docker: all env vars are provided by real env vars. I'll submit a PR when i get a moment. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is useful for other people - but I'm sharing it, and you can just reject it if not :)
I got here because I'm building a docker image, with all my code, and optimising it for prod run time, so I've run
composer dump-env prod- but I want to use the same image to run my tests - so I'm testing in the prod system. But actually this is easy to repeat in your dev environment, if you dump prod, and leave it there, you no longer get.env.devloaded.Basically if
.env.local.phpexists, the environment no longer properly switches, as the.env.$envfiles are not used. This PR changes this so that the correct env is always loaded.