[symfony/framework-bundle/5.3] remove "controller.service_arguments" #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
derrabus
approved these changes
Mar 24, 2021
chalasr
approved these changes
Mar 24, 2021
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 18, 2021
…unglas) This PR was squashed before being merged into the 5.3 branch. Discussion ---------- [FrameworkBundle] fix docs for controller as services Without this change, controllers not extending `AbstractController` aren't registered as services since symfony/recipes#915. Commits ------- cad2c97 [FrameworkBundle] fix docs for controller as services
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lines are hard to explain and understand, and they cover advanced use cases.
Let's keep things simple.
Also, this use case should be better covered by symfony/symfony#40555 in the future.