-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Closed
Labels
actionableClear and specific issues ready for anyone to take them.Clear and specific issues ready for anyone to take them.good first issueIdeal for your first contribution! (some Symfony experience may be required)Ideal for your first contribution! (some Symfony experience may be required)hasPRA Pull Request has already been submitted for this issue.A Pull Request has already been submitted for this issue.
Description
http://symfony.com/doc/current/contributing/code/core_team.html#pull-request-merging-policy
A pull request can be merged if:
- Enough time was given for peer reviews (a few minutes for typos or minor changes, at least 2 days for "regular" pull requests, and 4 days for pull requests with "a significant impact");
- It is a minor change [1], regardless of the number of votes;
Rule (1) says that minor changes need a few minutes of peer review time, while rule (2) states that it can be merged immediately.
Besides this, "a few minutes for typos or minor changes" is redundant, as typos are already included in minor changes according to footnote 1 ("Minor changes comprise typos, DocBlock fixes, code standards violations, and minor CSS, JavaScript and HTML modifications.").
At last, the comma before "and" in footnote 1 has to be removed.
Metadata
Metadata
Assignees
Labels
actionableClear and specific issues ready for anyone to take them.Clear and specific issues ready for anyone to take them.good first issueIdeal for your first contribution! (some Symfony experience may be required)Ideal for your first contribution! (some Symfony experience may be required)hasPRA Pull Request has already been submitted for this issue.A Pull Request has already been submitted for this issue.