Deprecated services docs sounds missing...

[mickaelandrieu]

I don't see any reference on the deprecated attribute available when we declare services in docs...

In pdf (before the generation was broken), we had something like:

The docs also say:

The ability to "un-deprecate" a service is possible only when declaring the definition in PHP.

I'd like to see an example, I can't retrieve any reference in docs too.

Mickaël

[wouterj]

You mean http://symfony.com/doc/current/service_container/alias_private.html#deprecating-services ?

[mickaelandrieu]

Yes (thank you, I don't know how to do to find something in website: I want your technique!).

I don't realy understand the ability to "un-deprecate": I mean, in PHP you could do:

$container
    ->register('acme.my_service', '...')
    ->setDeprecated(
        false, // so, it's undeprecated, right ?
        'The "%service_id%" service is deprecated since 2.8 and will be removed in 3.0.'
    )
;

What is the interest to do it instead of just remove the setDeprecated() call ?

[wouterj]

What is the interest to do it instead of just remove the setDeprecated() call ?

I think to be able to undeprecate services in a compiler pass or DI extension. To be honest, I don't really understand why you want it either.

Yes (thank you, I don't know how to do to find something in website: I want your technique!).

It's mostly just because I saw a PR writing/tweaking the docs about it, so I know where to look for. (knowing where to find stuff is easier than knowing the stuff)

[mickaelandrieu]

I think to be able to undeprecate services in a compiler pass or DI extension.

True, pretty much an edge case.

Thank you for help, it's more clear to me. Don't you think we may adapt your sentence in docs ? Something like:

In some cases, you may need to "un-deprecate" services, you can do it in PHP, for instance using a Compiler Pass:

$definition = $container->get('acme.my_service');
$definition->setDeprecated(false);

Mickaël

[javiereguiluz]

I'm not sure we want to document this. @mickaelandrieu your example works perfectly ... but this "feature" is probably something we don't want to promote, so I'd vote to not document it.

[xabbuh]

I do not see much value for this "feature". Imo we should simply remove the caution.

[mickaelandrieu]

I agree, do you want me to make a pull request to remove it ?

[xabbuh]

I would be happy to merge it. :)

[javiereguiluz]

Closing it as fixed by #7077.