[Messenger] add XML and PHP code blocks #10044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # Step 1: a factory class is registered as a service with the required | ||
| # dependencies to instantiate a middleware | ||
| doctrine.orm.messenger.middleware_factory.transaction: |
There was a problem hiding this comment.
Unrelated to this but ... is there any reason for keep using snake-case IDs for services instead of FQCN IDs?
There was a problem hiding this comment.
Here, potentially there could be other service for this class too. If they all used the class name as the service id would cause conflicts. So I think it's better to use custom IDs for these services.
|
Thank you Christian. |
javiereguiluz
added a commit
that referenced
this pull request
Jul 12, 2018
This PR was merged into the 4.1 branch. Discussion ---------- [Messenger] add XML and PHP code blocks Commits ------- e022215 add XML and PHP code blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.