Fixing bad logic, caused by merge originally #10516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Ryan! |
javiereguiluz
added a commit
that referenced
this pull request
Oct 19, 2018
This PR was merged into the 3.4 branch. Discussion ---------- Fixing bad logic, caused by merge originally Caught by @fnash in Symfony Slack! Because the `supports()` method didn't exist in 2.8, this logic basically needed to be reversed when we merged to 3.4. But, that was not done correctly (by me). Commits ------- 4e473c0 Fixing bad logic, caused by merge originally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caught by @fnash in Symfony Slack! Because the
supports()method didn't exist in 2.8, this logic basically needed to be reversed when we merged to 3.4. But, that was not done correctly (by me).