Update encore/copy-files.rst: add note about using versioning with custom target path #10792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added a commit
that referenced
this pull request
Jan 3, 2019
…oning with custom target path (mhujer) This PR was merged into the 3.4 branch. Discussion ---------- Update encore/copy-files.rst: add note about using versioning with custom target path Improving https://symfony.com/doc/current/frontend/encore/copy-files.html#referencing-image-files-from-a-template If the versioning is enabled in Encore and you want to use custom target path, you need to manually include the hash in the target filename. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 1a33da0 Update encore/copy-files.rst: add note about using versioning with custom target path
|
@mhujer thanks and congrats on your first Symfony Docs contribution! While merging we reworded it a bit to include your proposal inside the code example. We usually do that to make things easier to follow and put the explanations right in the code examples (when possible). Thanks! |
nikophil
pushed a commit
to nikophil/symfony-docs
that referenced
this pull request
Jan 3, 2019
…g versioning with custom target path (mhujer) This PR was merged into the 3.4 branch. Discussion ---------- Update encore/copy-files.rst: add note about using versioning with custom target path Improving https://symfony.com/doc/current/frontend/encore/copy-files.html#referencing-image-files-from-a-template If the versioning is enabled in Encore and you want to use custom target path, you need to manually include the hash in the target filename. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 1a33da0 Update encore/copy-files.rst: add note about using versioning with custom target path
|
@javiereguiluz Awesome, thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving https://symfony.com/doc/current/frontend/encore/copy-files.html#referencing-image-files-from-a-template
If the versioning is enabled in Encore and you want to use custom target path, you need to manually include the hash in the target filename.