Skip to content

Update remember_me.rst #11954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2019
Merged

Update remember_me.rst #11954

merged 1 commit into from
Jul 16, 2019

Conversation

alexsaalberg049
Copy link
Contributor

Change sentence to make sense in its context by adding the word 'not'

@javiereguiluz javiereguiluz added this to the 4.2 milestone Jul 16, 2019
@javiereguiluz
Copy link
Member

javiereguiluz commented Jul 16, 2019 •
edited
Loading

@alexsaalberg049 nice catch! This comes from the 3.4 version, which used a different wording and then, it was changed in 4.2 branch and included this mistake. So, we've merged this fix in 4.2 branch and then, in all the other branches.

Thanks ... and congrats on your first Symfony Docs contribution.

@alexsaalberg049 @javiereguiluz
Update remember_me.rst
113c63a 
Change sentence to make sense in its context by adding the word 'not'
@javiereguiluz javiereguiluz changed the base branch from 4.3 to 4.2 July 16, 2019 10:04
@javiereguiluz javiereguiluz merged commit 113c63a into symfony:4.2 Jul 16, 2019
javiereguiluz added a commit that referenced this pull request Jul 16, 2019
@javiereguiluz
minor #11954 Update remember_me.rst (alexsaalberg049)
6469b35 
This PR was submitted for the 4.3 branch but it was merged into the 4.2 branch instead (closes #11954).

Discussion
----------

Update remember_me.rst

Change sentence to make sense in its context by adding the word 'not'

Commits
-------

113c63a Update remember_me.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@alexsaalberg049 @javiereguiluz @carsonbot