Skip to content

[Form] Use a backed string enum in the EnumType example #16351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2022
Merged

[Form] Use a backed string enum in the EnumType example #16351

merged 1 commit into from
Jan 3, 2022

Conversation

Einenlum
Copy link
Contributor

A backed enum must declare the type of backed enum. Not declaring it is
not valid.

See PHP documentation.

This PR is based on 5.4 since the EnumType appeared in this version.

@Einenlum
Use a backed string enum in the EnumType example
132e0b9 
A backed enum must declare the type of backed enum. Not declaring it is
not valid.
@Einenlum Einenlum requested a review from xabbuh as a code owner December 31, 2021 10:41
@carsonbot carsonbot added this to the 5.4 milestone Dec 31, 2021
@carsonbot carsonbot changed the title Use a backed string enum in the EnumType example [Form] Use a backed string enum in the EnumType example Jan 3, 2022
@javiereguiluz
Copy link
Member

Good catch, thanks Yann.

@javiereguiluz javiereguiluz merged commit 18d41cc into symfony:5.4 Jan 3, 2022
@Einenlum Einenlum deleted the fix/backed-enum branch January 3, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Einenlum @javiereguiluz @carsonbot