Skip to content

[Reference] field dependent empty_data option description #4033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

[Reference] field dependent empty_data option description #4033

wants to merge 8 commits into from

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 17, 2014

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #4007
  • choice
  • collection
  • country
  • currency
  • email
  • entity
  • file
  • form
  • integer
  • language
  • locale
  • money
  • number
  • password
  • percent
  • radio
  • search
  • text
  • textarea
  • timezone
  • url

This is not yet complete. But I'm not sure if I like the way it looks now with the default value below the note directive.

This is accidentally opened against the master branch. Though it should get merged into the 2.3 branch.

@xabbuh xabbuh changed the title field dependent empty_data option description [WIP] field dependent empty_data option description Jul 17, 2014
wouterj
wouterj reviewed Jul 18, 2014
View reviewed changes
reference/forms/types/choice.rst

* If ``multiple`` is ``false`` and ``expanded`` is ``false``, then ``''``
(empty string);
* Otherwise ``array()`` (empty string).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string -> array (same in the rest of this PR)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Must be a copy-and-paste mistake. Would you place "(empty array)" at the end? I would just have removed it.

@wouterj
Copy link
Member

wouterj commented Jul 18, 2014

This is not yet complete. But I'm not sure if I like the way it looks now with the default value below the note directive.

Agreed, what about splitting it in empty_data_header.rst.inc and empty_data_footer.rst.inc? Or using the nice end-before and start-after options of the include directive

@xabbuh
Copy link
Member Author

xabbuh commented Jul 18, 2014

Or using the nice end-before and start-after options of the include directive

Apparently, you can include only parts of the document using start-after and end-before. With these options we can place something like DEFAULT_PLACEHOLDER in the empty_data description to wrap the file around the actual default data. What do you think?

@xabbuh
Copy link
Member Author

xabbuh commented Jul 18, 2014

There is another issue I noticed which I'm not sure of if it should be handled here. Currently, the the radio type includes the generic empty_data option description. Though, it extends the checkbox which has its own description. So wouldn't it make sense to include the description from the checkboxtype here too?

@xabbuh
Copy link
Member Author

xabbuh commented Jul 20, 2014

Changed the included file in the radio type and reworded the checkbox_empty_data.rst.inc file a bit.

@xabbuh xabbuh changed the title [WIP] field dependent empty_data option description [WIP][Reference] field dependent empty_data option description Jul 20, 2014
xabbuh and others added 7 commits July 26, 2014 21:54
@xabbuh
fix parent form types
0af354f 
The parent type of both the email type and the textarea type is not
the form type but instead the text type.
@javiereguiluz
Added a note about permissions in the Quick Tour
646a00c
@javiereguiluz
Fixed a wrong documentation reference (thanks @wouterj)
93b457e
@javiereguiluz
Minor rewording and fixed one reference
bed2602
@javiereguiluz
Added the missing title for a reference
141cf5e
@weaverryan
minor symfony#4070 Added a note about permissions in the Quick Tour (…
a4bdb97 
…javiereguiluz)

This PR was merged into the 2.3 branch.

Discussion
----------

Added a note about permissions in the Quick Tour

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3+
| Fixed tickets | symfony#4062

Commits
-------

141cf5e Added the missing title for a reference
bed2602 Minor rewording and fixed one reference
93b457e Fixed a wrong documentation reference (thanks @wouterj)
646a00c Added a note about permissions in the Quick Tour
@weaverryan
bug symfony#4063 fix parent form types (xabbuh)
1b695b5 
This PR was merged into the 2.3 branch.

Discussion
----------

fix parent form types

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | part of symfony#2360

The parent type of both the email type and the textarea type is not the form type but instead the text type.

Commits
-------

0af354f fix parent form types
@xabbuh xabbuh changed the title [WIP][Reference] field dependent empty_data option description [Reference] field dependent empty_data option description Aug 2, 2014
@xabbuh xabbuh mentioned this pull request Aug 2, 2014
Merged
21 tasks
@xabbuh
Copy link
Member Author

xabbuh commented Aug 2, 2014

replaced by #4083

@xabbuh xabbuh closed this Aug 2, 2014
weaverryan added a commit that referenced this pull request Aug 13, 2014
@weaverryan
bug #4083 [Reference] field dependent empty_data option description (…
d699255 
…xabbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[Reference] field dependent empty_data option description

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #4007

- [x] choice
- [x] collection
- [x] country
- [x] currency
- [x] email
- [x] entity
- [x] file
- [x] form
- [x] integer
- [x] language
- [x] locale
- [x] money
- [x] number
- [x] password
- [x] percent
- [x] radio
- [x] search
- [x] text
- [x] textarea
- [x] timezone
- [x] url

Replacement of #4033.

Commits
-------

6b61260 field dependent empty_data option description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @wouterj @javiereguiluz @weaverryan