[RFC] remove duplicated explanation #5482
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $ php app/console server:stop | ||
|
|
||
| .. tip:: | ||
| See the Installtion Manual. :doc:`/book/installtion`. |
There was a problem hiding this comment.
Minor typo: :doc:/book/installtion --> :doc:/book/installation
|
@jackdelin thank you, fixed it. |
DQNEO
changed the title
|
@DQNEO I love this pull request. This "deduplication" is really the right thing to do and it will simplify the work of our doc managers. I've created a new pull request (#5497) to reword the text that explains where to look for the Symfony installation help. Of course I took your original commits from this pull request, so you won't lose the credit of your work. Thanks! |
|
@DQNEO @javiereguiluz Do you suggest to close here in favor of #5497 or do you like to discuss both things separately? |
|
I closed this one. |
|
We made it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thank you very much for your great effort to maintain this documentation.
I am one of Symfony newbies, and I felt reading documentation is a little bit difficult.
One of the reasons is that there is some duplication of explanations.
I know this PR is a kind of controversial one, but removing duplication would make less confusion for new comers.