added commas for php code section #8663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added commas for php code section to prevent syntax error for those whom may copy and paste the code from the documents.
javiereguiluz
approved these changes
Nov 15, 2017
There was a problem hiding this comment.
@Maghrooni thanks for fixing this bug and congrats on your first contribution to Symfony Docs!
|
Good catch, thanks @Maghrooni. |
xabbuh
added a commit
that referenced
this pull request
Nov 15, 2017
This PR was merged into the 3.3 branch. Discussion ---------- added commas for php code section added commas for `php` code section to prevent syntax error for those whom may copy and paste the code from the documents. Commits ------- 21e9438 added commas for php code section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added commas for
phpcode section to prevent syntax error for those whom may copy and paste the code from the documents.