test: vinyl/gh.test.lua fix mistake #6168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found that in one previous commit 42c64d0 ('test: fix hanging of vinyl/gh.test.lua') Was mistakenly made such change: -while finished ~= 2 do fiber.sleep(0.01) end +test_run:wait_cond(function() return finished ~= 2 end) And the logic of the check was broken. This patch fixes it. Part of #5141 Fixes tarantool/test-run#261 Part of tarantool/tarantool-qa#106
avtikhon
force-pushed
the
avtikhon/gh-crash-gh
branch
from
0535197 to
0e8e067
Compare
avtikhon
force-pushed
the
avtikhon/gh-crash-gh
branch
from
0e8e067 to
0716b02
Compare
Totktonada
approved these changes
Jun 21, 2021
test_run:wait_cond() will check for it. |
Will it fail from time to time? AFAIU, it is why you created 42c64d0 in the first place. |
kyukhin
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that in one previous commit
Was mistakenly made such change:
And the logic of the check was broken. This patch fixes it.
Part of tarantool/tarantool-qa#205
Fixes tarantool/test-run#261
Part of tarantool/tarantool-qa#106