downgrade to protobuf 3 to satisfy temporary workaround #184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This PR essentially reverts the protobuf 4 upgrade changes that were merged into main as part of #136. The intent of this PR is to create a workaround for projects that incur unresolvable package dependency issues caused by the upgrade and is NOT meant to be merged into main.
Relevant Slack thread in Temporal Slack community: https://temporalio.slack.com/archives/CTT84RS0P/p1667336466199119
Why?
temporalio==0.1b2
introduced some nice changes like the testing module but also upgrades the protobuf dependency toprotobuf < 4.22, >= 4.21
which can cause issues in existing projects that utilize packages that don't support protobuf 4. As a workaround, this PR downgrades the protobuf package and attempts to create a wheel that includes the 0.1b2 changes excluding the protobuf upgrade.Checklist
This PR doesn't close any issues but the relevant issue to track this is [Feature Request] Review options for allowing protobuf 3.x to work with this library #181
How was this tested:
As long as CI passes I think we're good?
Any docs updates needed?
None needed I believe