Skip to content

Added more context to the README sections #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 8, 2022
Merged

Conversation

mbernier
Copy link
Contributor

@mbernier mbernier commented Dec 8, 2022

What was changed

Added context to the Quick Start along with links to the reference material at the top of the README Added context to the Usage section
Added a separator between Quick Start and Usage, as well as adjusting the headers to specifically call out the different sections as physically and logically different.

Why?

I got confused while working through the README and totally missed the links at the top, bc I got distracted and excited about "Quick Start"

Checklist

  1. README change only, no testing needed
  2. My header changes may throw off the TOC generator, apologies if it makes the TOC look awful...

Added context to the Quick Start along with links to the reference material at the top of the README
Added context to the Usage section
Added a separator between Quick Start and Usage, as well as adjusting the headers to specifically call out the different sections as physically and logically different.
@CLAassistant
Copy link

CLAassistant commented Dec 8, 2022

CLA assistant check
All committers have signed the CLA.

@mbernier
Copy link
Contributor Author

mbernier commented Dec 8, 2022

@cretz I believe I have resolved all the comments. Please let me know if you see anything else. Thanks for catching my inconsistencies!

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll merge after CI runs.

@cretz cretz merged commit 1f72c98 into temporalio:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants