Skip to content

Expose core "runtime" as temporalio.runtime.Runtime #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 4, 2023
Merged

Expose core "runtime" as temporalio.runtime.Runtime #240

merged 5 commits into from
Jan 4, 2023

Conversation

cretz
Copy link
Member

@cretz cretz commented Jan 4, 2023

What was changed

  • Updated core
  • Moved user-facing runtime customization to temporalio.runtime.Runtime
    • Removed some user-facing stuff out of the bridge part
    • Marked this module as experimental

💥 This is a backwards incompatible change to APIs we had marked subject to change (because we knew this was coming)

Checklist

  1. Closes [Feature Request] Move the user-facing parts in temporalio.bridge.runtime to somewhere stable #230

@cretz cretz requested a review from a team January 4, 2023 20:49
bergundy
bergundy approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed this one, lgtm

@cretz cretz merged commit f252e36 into temporalio:main Jan 4, 2023
@cretz cretz deleted the expose-runtime branch January 4, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy approved these changes

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Move the user-facing parts in temporalio.bridge.runtime to somewhere stable
3 participants
@cretz @bergundy @Sushisource