Skip to content

Rework grpc locations and add some different structure #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 31, 2022
Merged

Rework grpc locations and add some different structure #3

merged 6 commits into from
Jan 31, 2022

Conversation

cretz
Copy link
Member

@cretz cretz commented Jan 31, 2022

What was changed

  • temporalio/proto/temporal/api -> temporalio/api
  • temporalio/proto/dependencies -> temporalio/api/dependencies
  • temporalio/proto/temporal/sdk -> temporalio/bridge/proto
  • Add aliases for all protos/grpc to top-level of respective module for clarity
  • Add LICENSE
  • Add simple pure-python gRPC test
  • Add isort to format/lint task
  • Add mypy lint check and mypy-protobuf support
  • Add pytest task

(carryover from #2)

@cretz cretz requested review from bergundy and Sushisource January 31, 2022 17:36
@bergundy
Copy link
Member

Already reviewed in #2

@cretz cretz merged commit a3d5328 into temporalio:main Jan 31, 2022
@cretz cretz deleted the structure1 branch March 18, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy approved these changes

@Sushisource Sushisource Awaiting requested review from Sushisource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cretz @bergundy