Skip to content

Call JSON type converters recursively #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2023
Merged

Call JSON type converters recursively #304

merged 2 commits into from
Mar 30, 2023

Conversation

cretz
Copy link
Member

@cretz cretz commented Mar 27, 2023

What was changed

Properly call JSON type converters recursively. Also fixate the Poetry version in CI due to Poetry bug.

Checklist

  1. Closes [Bug] JSONTypeConverter not applied recursively #289

@cretz cretz requested a review from a team March 27, 2023 16:32
@cretz cretz marked this pull request as draft March 27, 2023 16:41
@cretz
Copy link
Member Author

cretz commented Mar 27, 2023 •
edited
Loading

Converting to draft while I fix CI

EDIT: Fixed. Yet another Poetry issue.

@cretz cretz marked this pull request as ready for review March 27, 2023 17:28
@cretz cretz mentioned this pull request Mar 30, 2023
Merged
@cretz cretz merged commit d790468 into temporalio:main Mar 30, 2023
@cretz cretz deleted the recursive-json-converter branch March 30, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] JSONTypeConverter not applied recursively
2 participants
@cretz @Quinn-With-Two-Ns