Worker Versioning #340
Merged
Worker Versioning #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
force-pushed
the
worker-versioning
branch
from
78e9ece to
d10ecf5
Compare
cretz
reviewed
Jul 10, 2023
There was a problem hiding this comment.
Looks great, only minor things for discussion (and most just subjective). Don't forget to run poe format to format files and can poe lint to make sure type checking and doc-format checking are done.
Also, can you close and delete the branch for #107?
cretz
reviewed
Jul 10, 2023
temporalio/client.py
Outdated
| @@ -831,6 +832,108 @@ async def list_schedules( | |||
| ) | |||
| ) | |||
|
|
|||
| async def update_worker_build_id_compatability( | |||
There was a problem hiding this comment.
Suggested change
| async def update_worker_build_id_compatability( | |
| async def update_worker_build_id_compatibility( |
Just caught this, sorry. Update everywhere.
There was a problem hiding this comment.
Baaaaah I do that every time lol. Thanks for catching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add support for new worker versioning feature
Why?
Parity
Checklist
Closes Worker versioning support #335
How was this tested:
Added tests
Any docs updates needed?
Yes to follow