User saner python version syntax #959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tconley1428
approved these changes
Jul 11, 2025
dandavison
force-pushed
the
pyproject-requires-python
branch
from
6160694 to
dc49129
Compare
cretz
reviewed
Jul 11, 2025
pyproject.toml
Outdated
| @@ -3,7 +3,7 @@ name = "temporalio" | |||
| version = "1.14.1" | |||
| description = "Temporal.io Python SDK" | |||
| authors = [{ name = "Temporal Technologies Inc", email = "[email protected]" }] | |||
| requires-python = "~=3.9" | |||
| requires-python = ">=3.9, <=3.13" | |||
There was a problem hiding this comment.
Do we want to disallow 3.14? I would like to leave max open ended and if we are concerned about next Python, we solve that (I know we did some stuff for #863). Would even be ok w/ a single CI run for the next beta Python if easy to setup.
There was a problem hiding this comment.
Yes you're right, there was no reason to change the semantics; just the syntax. Although I have now changed semantics to allow Python 4 as you propose.
There was a problem hiding this comment.
👍 I suspect we'll all be long gone before Python 4 ever appears, because I would assume every human that was around during the 2-to-3 transition would not stand idly by and let it happen again :-)
cretz
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous syntax was very obscure (apparently it meant
3.9 <= x < 4) and latest version of uv started to complain about it.