Type-checking cleanups #962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AI: This commit should always be force-pushed to a branch
on the remote named pyright-2.
dandavison
commented
Jul 14, 2025
| @@ -556,7 +557,7 @@ class NonSerializableOutputFailure(_FailureTestCase): | |||
| ) | |||
| @pytest.mark.parametrize("with_service_definition", [True, False]) | |||
| async def test_start_operation_happy_path( | |||
| test_case: Type[_TestCase], | |||
| test_case: type[_TestCase], | |||
There was a problem hiding this comment.
I'll make the Type -> type change globally at some point, hopefully when it's enforced by CI. For now I'm just doing it in Nexus code.
cretz
approved these changes
Jul 14, 2025
| @@ -45,7 +45,7 @@ dev = [ | |||
| "psutil>=5.9.3,<6", | |||
| "pydocstyle>=6.3.0,<7", | |||
| "pydoctor>=24.11.1,<25", | |||
| "pyright==1.1.402", | |||
| "pyright==1.1.403", | |||
There was a problem hiding this comment.
Asked similarly at nexus-rpc/sdk-python#13 (comment), should we fixate to a specific Pyright version? Will this ensure we miss new things that may effect our users in later versions? I see we use a fixed mypy version too. I don't necessarily mind it so long as we keep on top of updating regularly.
There was a problem hiding this comment.
Good question, let's consider changing to something like >= 1.1 in a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves us towards the goal of zero in-IDE type-errors, enforced by CI.