Skip to content

Add build workflow via docker #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

aktech
Copy link
Member

@aktech aktech commented Sep 23, 2024

Adds build workflow via docker based on the instructions specified here: https://github.com/tensorflow/data-validation#build-with-docker

@peytondmurray
Copy link
Contributor

peytondmurray commented Sep 25, 2024

I think we also need to add the part of the workflow that automatically uploads to PyPI for releases, like this https://github.com/tensorflow/tfx/pull/6892/files.

One other thing - can you add a workflow_dispatch trigger? It's sometimes useful for debugging or manually releasing.

Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need a pip install twine before running twine check.

@peytondmurray peytondmurray self-requested a review September 29, 2024 23:20
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peytondmurray peytondmurray merged commit bca0f85 into tensorflow:master Oct 1, 2024
5 checks passed
@aktech aktech deleted the build-workflow branch October 1, 2024 08:57
@aktech aktech mentioned this pull request Oct 4, 2024
4 tasks
andrewfulton9 pushed a commit to andrewfulton9/data-validation that referenced this pull request Jun 12, 2025
* Add build workflow via docker

* rename docker-compose to docker compose

* add twine check and upload to PyPi

* add workflow_dispatch

* install twine before twine check
peytondmurray pushed a commit that referenced this pull request Jun 12, 2025
* Add build workflow via docker (#259)

* Add build workflow via docker

* rename docker-compose to docker compose

* add twine check and upload to PyPi

* add workflow_dispatch

* install twine before twine check

* add testing workflow

* single python

* trigger

* install in build job

* install pytest

* install test dependencies

* add xfail to tests

* add reusable workflows and add pr number in xfail

* fix composite action

* add more xfails

* xfail top_k_uniques_stats_generator_test.py

* xfails in partitioned_stats_generator_test.py

* more xfails

* add missing imports

* fix extra decorators

* more xfails

* Fix TAP and Kokoro tests caused by NumPy v2 migration.
1. To ensure test compatibility between NumPy v1 and v2 environments, we've adjusted the comparison tolerance to 1e-4. This accommodates slight variations (around 1e-4) in floating-point outcomes between the two NumPy versions. Additionally, we've modified the expected proto float to align with NumPy v2 results.
2. For mutual_information, NumPy v2 is able to handle values > 2**53 if the min and max of the examples are the same. However, since we need to be compatible with NumPy v1 and v2, for related unit tests, we check for the NumPy version before running the associated unit tests.

PiperOrigin-RevId: 681598675

* use xfail instead of skip

* remove xfails that are passing

* dont run xfail + add test deps

* fix build failure by pinning tensorflow_metadata

* move test requirements

* debugging

* more debugging

* remove upload for testing

* add environment variable to build nightly

* add extra-index-url

* trying to use nightly install

* revert debugging changes

* update upload artifact version

* revert metadata branch back to master

* fix typo

* remove install when built, move to only install on test

* change name of step checking the wheel after moving install to test workflow

* update PR number

* just remove PR

---------

Co-authored-by: Amit Kumar <[email protected]>
Co-authored-by: tf-data-validation-team <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants