Fix most tests that break with es2020 output.

[bmd3k]

The migration to spec_bundle() will require we configure the TypeScript compiler to output to JavaScript 'es2020'. For the most part, this will require very little changes to our code. There is one glaring exception, though, that we mostly address in this PR.

The following pattern will break:

in my_utilities.ts:

export function myFuncToSpyOn() {
  // Some code.
}

in my_test.ts:

import * as my_utilities from './my_utilities'

spyOn(my_utilities, 'myFuncToSpyOn').and.returnValue(1);

The Jasmine library will complain:
Error: <spyOn> : myFuncToSpyOn is not declared writable or has no setter

Jasmine is aware of the issue but can't provide a fix:

• Error: <spyOn> : openSnackbar is not declared writable or has no setter while spyOn import a method in Angular 12 (Jasmin) jasmine/jasmine#1942
• https://jasmine.github.io/pages/faq.html#module-spy

Instead they suggest we refactor our code so that the functions being spied on are wrapped in some Class or other Object.

This PR does exactly that, for the most part doing the most simple of wrapping:

now in my_utilities.ts:

// No longer exported.
function myFuncToSpyOn() {
  // Some code.
}

export const MyUtilities = {
  myFuncToSpyOn
}

now in my_test.ts:

import {MyUtilities} from './my_utilities'

spyOn(MyUtilities, 'myFuncToSpyOn').and.returnValue(1);

The change has a bit of bigger blast radius because not only do the tests need to be changed but so does every other file (test or not) that are using the utility functions.

[JamesHollyer]

Can we continue to export these so that we can import them directly in places other than the tests?

[bmd3k]

If code uses the functions directly then they won't be using the mocks.

For example:

If the code you're writing does this:

function myFunction() {
  return convertRectToExtent(this.someRect);
}

But your test does this:

spyOn(ChartUtils, 'convertRectToExtent').and.returnValue(someExtent);
expect(myFunction()).toEqual(someExtent);

It won't work. Because you're replacing what ChartUtils.convertRectToExtent points to with a mock/spy but raw convertRectToExtent remains unmodified.

[JamesHollyer]

Ah yea that makes sense. Dang ok I guess we have to do it this way.

[japie1235813]

This breaks the sync. Would you mind working on the fix?
See cl/487331149. Thanks