Adds hparam column persistence #6728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyajones
approved these changes
Jan 22, 2024
Oh.. great point, I hadn't considered this. I'll include a fix downstream that will only display columns for It makes me also consider, does it make sense to store a list of hparams per experiment ID? But I think we can get back to this later: v1 of this feature should still be very useful as-is, and we can always add per-experiment logic if users really need it. IIUC hparam filters are also not stored per-experiment yet, which also supports deferring this for now. |
## Motivation for features / changes Before enabling context menus for scalar card tables, it will be useful to explicitly distinguish the two different removal related column interactions that are currently available: "remove" and "hide". "Removed" columns must be re-added to display again (this is what's currently done for hparams in the runs table). "Hidden" columns can be re-enabled via the "edit table columns" (this is only available in scalar tables). Distinguishing these two operations also provides an easy way to provide similar but different hparam columns for the runs and scalar tables: first add the hparams that you need to both tables, then hide the ones you don't need in the scalar tables. ## Technical description of changes - adds a `hidable` property to the ColumnHeader type. - properly initializes ColumnHeader context menu options in the runs and metrics reducers, and overrides any options set in localstorage. This will effectively turn context options into static, system-defined features. - disables movability and removability for RUN columns. This should have negligible impact on usability while allowing us to define useful column orderings such as `| run | hparam_columns | other_columns |` ## Detailed steps to verify changes work correctly (as executed by you) - Unit tests pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Scalar card table columns are currently persisted to localstorage; it should be reasonable to save selected hparam columns to localstorage as well.
Technical description of changes
Adds a new
dashboardDisplayedHparamColumnsPersistableSetting to save selected hparam columns (similar to the existingsingleSelectionHeadersandrangeSelectionHeaderssettings)Detailed steps to verify changes work correctly (as executed by you)
Unit tests pass