Skip to content

fix(deps): update to github.com/shirou/gopsutil/v4 #2964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

zchee
Copy link
Contributor

@zchee zchee commented Feb 3, 2025

macOS Sequoia beta occur "relocation target mach_task_self_ not defined" error

What does this PR do?

Update github.com/shirou/gopsutil/v3 to github.com/shirou/gopsutil/v4.

Why is it important?

Occur relocation target mach_task_self_ not defined error In the gopsutil v3 because using cgo and mach_task_self_ removed in macOS Sequoia beta.

Related issues

@zchee zchee requested a review from a team as a code owner February 3, 2025 13:10
Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 9748460
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/67a1e44fceac1a0009261f8b
😎 Deploy Preview https://deploy-preview-2964--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

stevenh
stevenh previously approved these changes Feb 4, 2025
Copy link
Contributor

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdelapenya
Copy link
Member

@zchee could you please run make tidy-all from the root of the project? It will apply the dependencies to all modules. 🙏

@mdelapenya mdelapenya added the dependencies Dependencies or external services label Feb 4, 2025
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will approve one the gopsutil dependency is propagated to the downstream modules.

Thanks for your contribution 🙇

macOS Sequoia beta occur "relocation target mach_task_self_ not defined"
error

Signed-off-by: Koichi Shiraishi <[email protected]>
@zchee
Copy link
Contributor Author

zchee commented Feb 4, 2025

@mdelapenya done make tidy-all, PTAL

Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for the CI to merge, thank you so much for your work here 🙇

@zchee
Copy link
Contributor Author

zchee commented Feb 4, 2025

@mdelapenya Failed test but it seems depends on Ollama container image...?
IIRC not related to this change.

@mdelapenya
Copy link
Member

@mdelapenya Failed test but it seems depends on Ollama container image...? IIRC not related to this change.

Indeed, will retrigger, but it LGTM. We opened #2965 as it started to happen in a consistent manner a few days ago.

@mdelapenya mdelapenya self-assigned this Feb 4, 2025
@mdelapenya mdelapenya merged commit 0d99308 into testcontainers:main Feb 4, 2025
126 checks passed
@zchee zchee deleted the gopsutil-v4 branch February 4, 2025 11:10
@zchee
Copy link
Contributor Author

zchee commented Feb 6, 2025

@mdelapenya One question related to our company's internal release schedule (because we use the testcontainers-go heavily. Thanks for developing the great framework :D

When will you cut a new release to include this change?

@mdelapenya
Copy link
Member

We do not have a strict release schedule, although I like cutting a monthly release. It also depends on the ongoing PRs, which I usually check if they need to be present in the release.

In the meantime, as a workaround, you can test these features pointing to main.

@zchee
Copy link
Contributor Author

zchee commented Feb 6, 2025

@mdelapenya I see, understand testcontainers release policy.
So, as you said, I'll pin current main branch commit hash in the go.mod with replace directive until next stable version. Thanks a lot :D

ttruongatl pushed a commit to ttruongatl/testcontainers-go that referenced this pull request Feb 15, 2025
macOS Sequoia beta occur "relocation target mach_task_self_ not defined"
error

Signed-off-by: Koichi Shiraishi <[email protected]>
Co-authored-by: Steven Hartland <[email protected]>
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Feb 20, 2025
* main: (54 commits)
  deps: update go version from 1.22.0 to 1.23.0 (testcontainers#2985)
  feat(redpanda): add bootstrap user account option (testcontainers#2975)
  chore(ollama): bump default version to 0.5.7 (testcontainers#2966)
  feat!: log package for consistent output (testcontainers#2979)
  docs: remove duplicated options in the customisers lists (testcontainers#2989)
  chore: exclude "modules/k6" from the build (testcontainers#2987)
  chore: enable var-naming from revive (private vars only) (testcontainers#2978)
  chore(deps): bump actions/checkout from 4.1.7 to 4.2.2 (testcontainers#2971)
  chore(deps): bump release-drafter/release-drafter from 6.0.0 to 6.1.0 (testcontainers#2970)
  chore!: remove variadic arguments from nats ConnectionString (testcontainers#2967)
  fix(ci): use same condition for sonar steps (testcontainers#2974)
  fix: return unique modified modules (testcontainers#2973)
  chore(deps): bump golangci/golangci-lint-action from 6.2.0 to 6.3.0 (testcontainers#2969)
  chore(ci): run lint in a separate build before running the tests (testcontainers#2876)
  fix(deps): update to github.com/shirou/gopsutil/v4 (testcontainers#2964)
  fix(valkey): fix port race (testcontainers#2962)
  chore(deps): bump golang.org/x/net in /modules/pinecone (testcontainers#2963)
  chore(deps): bump golang.org/x/net from 0.26.0 to 0.33.0 (testcontainers#2961)
  deps(fix): include modulegen templates dir in dependabot updates (testcontainers#2956)
  chore(deps): bump docker/setup-docker-action from 4.0.0 to 4.1.0 (testcontainers#2959)
  ...
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Feb 20, 2025
* main: (34 commits)
  deps: update go version from 1.22.0 to 1.23.0 (testcontainers#2985)
  feat(redpanda): add bootstrap user account option (testcontainers#2975)
  chore(ollama): bump default version to 0.5.7 (testcontainers#2966)
  feat!: log package for consistent output (testcontainers#2979)
  docs: remove duplicated options in the customisers lists (testcontainers#2989)
  chore: exclude "modules/k6" from the build (testcontainers#2987)
  chore: enable var-naming from revive (private vars only) (testcontainers#2978)
  chore(deps): bump actions/checkout from 4.1.7 to 4.2.2 (testcontainers#2971)
  chore(deps): bump release-drafter/release-drafter from 6.0.0 to 6.1.0 (testcontainers#2970)
  chore!: remove variadic arguments from nats ConnectionString (testcontainers#2967)
  fix(ci): use same condition for sonar steps (testcontainers#2974)
  fix: return unique modified modules (testcontainers#2973)
  chore(deps): bump golangci/golangci-lint-action from 6.2.0 to 6.3.0 (testcontainers#2969)
  chore(ci): run lint in a separate build before running the tests (testcontainers#2876)
  fix(deps): update to github.com/shirou/gopsutil/v4 (testcontainers#2964)
  fix(valkey): fix port race (testcontainers#2962)
  chore(deps): bump golang.org/x/net in /modules/pinecone (testcontainers#2963)
  chore(deps): bump golang.org/x/net from 0.26.0 to 0.33.0 (testcontainers#2961)
  deps(fix): include modulegen templates dir in dependabot updates (testcontainers#2956)
  chore(deps): bump docker/setup-docker-action from 4.0.0 to 4.1.0 (testcontainers#2959)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependencies or external services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants