ci(await-async-query): update node versions #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Drop support for node v8. Min version allowed is node v10.12
Belco90
added
BREAKING CHANGE
|
|
||
| jobs: | ||
| include: | ||
| - stage: release | ||
| if: branch = master AND type != pull_request |
There was a problem hiding this comment.
Suggested change
| if: branch = master AND type != pull_request | |
| if: branch = master AND type = push |
What do you think?
There was a problem hiding this comment.
Mmm I'm not sure. There are other types which I'm not sure if we are interested to trigger or not. Ignoring pull requests is the usual behavior I've seen in other packages.
thomaslombart
approved these changes
Mar 22, 2020
Belco90
added a commit
that referenced
this pull request
Mar 29, 2020
feat(await-async-utils): reflect waitFor changes (#89) feat: new rule no-wait-for-empty-callback (#94) feat: new rule prefer-wait-for (#88) feat: new rule prefer-screen-queries (#99) BREAKING CHANGE: drop support for node v8. Min version allowed is node v10.12 (#96) BREAKING CHANGE: rule `no-get-by-for-checking-element-not-present` removed in favor of new rule `prefer-presence-queries` (#98) Closes #85 Closes #86 Closes #90 Closes #92 Closes #95 Co-authored-by: timdeschryver <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Drop support for node v8. Min version allowed is node
v10.12