Skip to content

Fix typing for parity with React #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/resultContainer.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { ResolverType } from "./_types";

function resultContainer<R>(initialValue?: R) {
let value = initialValue;
function resultContainer<R>() {
let value: R | undefined;
let error: Error;
const resolvers: ResolverType[] = [];

Expand All @@ -10,7 +10,7 @@ function resultContainer<R>(initialValue?: R) {
if (error) {
throw error;
}
return value;
return value as R;
},
get error() {
return error;
Expand Down
8 changes: 4 additions & 4 deletions test/customHook.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,17 @@ describe("Custom hooks", () => {
test("should increment counter", () => {
const { result } = renderHook(() => useCounter());

act(() => result.current?.increment());
act(() => result.current.increment());

expect(result.current?.count).toBe(1);
expect(result.current.count).toBe(1);
});

test("should decrement counter", () => {
const { result } = renderHook(() => useCounter());

act(() => result.current?.decrement());
act(() => result.current.decrement());

expect(result.current?.count).toBe(-1);
expect(result.current.count).toBe(-1);
});
});

Expand Down
2 changes: 1 addition & 1 deletion test/useRef.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ describe("useHook tests", () => {

const refContainer = result.current;

expect(refContainer?.current?.fakeImperativeMethod()).toBe(true);
expect(refContainer.current?.fakeImperativeMethod()).toBe(true);
});
});