fix: correctly render wrapped components #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The render function now correctly renders the component if the wrapper option is set. Before
this it was rendering
<innerElement />
to the DOM.What:
Render the
WrapperComponent
directly using theh
function and pass theinnerElement
as a child component rather than using JSX syntax in the function. This is how it is done in the react testing library as well.Also updated the contributing link in the
CONTRIBUTING.md
file since the link pointed to a different project.Why:
Calling
render
with the wrapper option wasn't rendering the actual component, but<innerElement />
so tests would fail due to the component being tested not existing.How:
The
wrapUiIfNeeded
function was updated to directly create components using theh
function.Checklist: