UNION ALL is not supported

[Zheness]

Hello,

When trying a query with UNION ALL like SELECT a FROM users UNION ALL SELECT a FROM users it doesn't work with magic query.

If we look at the file StatementFactory.php, we see that only UNION is supported.

Is there any reason why it was not implemented?

Thanks !

[homersimpsons]

Is there any reason why it was not implemented?

I do not think there is any, are you willing to submit a patch for this?

I may have time to look into it later though.

[Zheness]

Hi,
I can try to submit a PR today.

How would you like me to do it ?

• A complete duplicate of the Union.php file to UnionAll.php?
• A simple boolean argument in the Union constructor?
• other ?

There is only one line to edit in the file, but I don't know how you prefer the code to be maintained.
Thanks !

[homersimpsons]

I think it makes sense to have a boolean. Because we can have either UNION DISTINCT which is like UNION or UNION ALL.

Looking at SELECT we have a boolean for this:

magic-query/src/SQLParser/Query/Select.php

Line 58 in 5107ebf

private $distinct;

So let's do the same with UNION ALL:

A simple boolean argument in the Union constructor?

Don't forget to add tests too.

[homersimpsons]

(published in v1.5.2)