Skip to content

In Oracle, table aliases cannot contain the AS keyword #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/SQLParser/Node/Table.php
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ public function toSql(array $parameters, AbstractPlatform $platform, int $indent
}
$sql .= $platform->quoteSingleIdentifier($this->table);
if ($this->alias) {
$sql .= ' AS '.$platform->quoteSingleIdentifier($this->alias);
$sql .= ' '.$platform->quoteSingleIdentifier($this->alias);
}
if ($this->hints) {
foreach ($this->hints as $hint) {
Expand Down
4 changes: 2 additions & 2 deletions tests/Mouf/Database/MagicQueryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -189,10 +189,10 @@ public function testStandardSelect()
$this->assertEquals('SELECT a FROM users UNION SELECT a FROM users', self::simplifySql($magicQuery->build($sql)));

$sql = 'SELECT a FROM users u, users u2';
$this->assertEquals('SELECT a FROM users AS u CROSS JOIN users AS u2', self::simplifySql($magicQuery->build($sql)));
$this->assertEquals('SELECT a FROM users u CROSS JOIN users u2', self::simplifySql($magicQuery->build($sql)));

$sql = 'SELECT a FROM users u WHERE status = (CASE WHEN u.id = 1 THEN u.status_1 ELSE u.status_2 END)';
$this->assertEquals('SELECT a FROM users AS u WHERE status = (CASE WHEN u.id = 1 THEN u.status_1 ELSE u.status_2 END)', self::simplifySql($magicQuery->build($sql)));
$this->assertEquals('SELECT a FROM users u WHERE status = (CASE WHEN u.id = 1 THEN u.status_1 ELSE u.status_2 END)', self::simplifySql($magicQuery->build($sql)));

$sql = 'SELECT 42 as fooalias FROM bar HAVING fooalias = 24';
$this->assertEquals('SELECT 42 AS fooalias FROM bar HAVING fooalias = 24', self::simplifySql($magicQuery->build($sql)));
Expand Down