Broken Function: array_all

[temp]

Function URL

https://www.php.net/manual/en/function.array-all.php

PHP Version

8.4

Safe Version

3.0.0

Description

It has return type void defined in safe, but should be bool

[shish]

I'd be more inclined to say that array_all doesn't belong in Safe at all, since false isn't an error...

But more broadly speaking, changing return types from "true on success, false on error" to "void on success, Exception on error" is kind of intentional - do you have a case where it makes sense to check the return value of a function which always returns a constant?

[temp]

I'd say stick with return - I'm using it in a if-block. I don't think it would be a good idea to throw an exception here.

[temp]

So, agreed, safe doesn't make sense here.

[shish]

For sake of keeping compatibility, I think a sensible path forwards for this category of issues ("functions which don't really belong in safe") would be:

• keep the existing function working how it works now
• flag it as deprecated
• remove it from the list of functions that phpstan will suggest using

Since this is the first time we've come across this category of issue in v3 it'll need some new code to be written on our end, so I'd suggest adding the phpstan suggestion to your ignore list for now 😓 (removing the function completely would be trivial, but will break anybody currently using it; we don't yet have a mechanism for "flag a function as a false-positive, so we keep it around for compatibility but don't recommend it to new users", so that'll need to be written)

[temp]

Sounds reasonable. I simply switched back to the global function and ignored the phpstan-error.
Thanks for your help!