Add falsy regexes, primarily for session functions #642
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three additional regexes to the falsies detection list:
'/&false;\s+for\s+failure/m'
catches some session functions and coincidentally also a mbstring function.'/On failure to change the value, &false; is returned./m'
specifically catchessession_cache_expire
andsession_cache_limiter
.'/This function returns &true; if a session was successfully started,\s+otherwise &false;./m'
specifically catchessession_start
.Method::stripReturnFalseText
has been modified to strip the descriptions where necessary.