Skip to content

Add falsy regexes, primarily for session functions #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

timsmid
Copy link
Contributor

@timsmid timsmid commented Mar 11, 2025

This PR adds three additional regexes to the falsies detection list:

  • '/&false;\s+for\s+failure/m' catches some session functions and coincidentally also a mbstring function.
  • '/On failure to change the value, &false; is returned./m' specifically catches session_cache_expire and session_cache_limiter.
  • '/This function returns &true; if a session was successfully started,\s+otherwise &false;./m' specifically catches session_start.

Method::stripReturnFalseText has been modified to strip the descriptions where necessary.

@shish
Copy link
Collaborator

shish commented Mar 12, 2025

Looks good, thank you <3

@shish shish merged commit ea6033e into thecodingmachine:master Mar 12, 2025
10 checks passed
@timsmid timsmid deleted the session-functions branch March 20, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants