Skip to content

Modify Error Creation Functions to Friend Functions #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 24, 2023
Merged

Modify Error Creation Functions to Friend Functions #86

merged 3 commits into from
Dec 24, 2023

Conversation

threeal
Copy link
Owner

@threeal threeal commented Dec 24, 2023 •
edited
Loading

This pull request resolves #82 by setting the errors::make and errors::format functions to be friend functionts of the error::Error class. It also modifies the Error::Error constructor to be private.

@threeal threeal added the feat label Dec 24, 2023
@threeal threeal self-assigned this Dec 24, 2023
@threeal threeal added this to the Version 1.0.0 milestone Dec 24, 2023
@threeal threeal marked this pull request as ready for review December 24, 2023 15:14
@threeal threeal merged commit b57f647 into main Dec 24, 2023
@threeal threeal deleted the impl-friend-functions branch December 24, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@threeal threeal

Labels
feat
Projects
None yet
Milestone
Version 1.0.0
Development

Successfully merging this pull request may close these issues.

Modify Error Creation Functions to Friend Functions
1 participant
@threeal