Skip to content

stat_count() respects uniqueness of x #5520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# ggplot2 (development version)

* `stat_count()` treats `x` as unique in the same manner `unique()` does
(#4609).

* `position_stack()` no longer silently removes missing data, which is now
handled by the geom instead of position (#3532).

Expand Down
3 changes: 1 addition & 2 deletions R/stat-count.R
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ StatCount <- ggproto("StatCount", Stat,
x <- data$x
weight <- data$weight %||% rep(1, length(x))

count <- as.numeric(tapply(weight, x, sum, na.rm = TRUE))
count[is.na(count)] <- 0
count <- as.vector(rowsum(weight, x, na.rm = TRUE))

bars <- data_frame0(
count = count,
Expand Down
11 changes: 11 additions & 0 deletions tests/testthat/test-stat-count.R
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,14 @@ test_that("stat_count() checks the aesthetics", {
p <- ggplot(mtcars) + stat_count(aes(factor(gear), mpg))
expect_snapshot_error(ggplot_build(p))
})

test_that("stat_count() respects uniqueness of `x`", {
# For #4609, converting x to factor loses smallest digits, so here we test
# if they are retained
df <- data_frame0(x = c(1, 2, 1, 2) + rep(c(0, 1.01 * .Machine$double.eps), each = 2))
p <- ggplot(df, aes(x)) + stat_count(position = "identity")
data <- layer_data(p)

expect_length(vec_unique(df$x), 4)
expect_equal(data$y, rep(1, 4))
})