Skip to content

Use new {scales} syntax #5544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Conversation

teunbrand
Copy link
Collaborator

Briefly, {scales} went from _pal and _trans suffixed functions to pal_ and transform_ prefixed functions in version 1.3.0. This PR propagates the prefixed versions throughout ggplot2.

Comment on lines +479 to +480
expect_equal(test_breaks(transform_boxcox(0), limits = c(1, 10)),
c(NA, 2.5, 5.0, 7.5, 10))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also activated this test

@teunbrand teunbrand added this to the ggplot2 3.5.0 milestone Nov 29, 2023
@teunbrand teunbrand requested a review from thomasp85 November 29, 2023 08:06
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit c00f875 into tidyverse:main Dec 4, 2023
@teunbrand teunbrand deleted the use_1.3.0_scales_api branch December 4, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants