Skip to content

Clarify that limits are given after expansion #5677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #3445.

It simply adds a line to the function option for breaks that position scales get expanded limits. Since discrete scales document their own breaks param, this should only appear in continuous and binned scales.

@teunbrand teunbrand requested a review from thomasp85 February 23, 2024 10:08
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 993c5bf into tidyverse:main Feb 27, 2024
@teunbrand teunbrand deleted the clarify_breaks_limits_interaction branch February 27, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify documentation of breaks function in scale_continuous
2 participants