feat: string concatenation #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. I'll delay merging this PR until laravel/framework#46558 is merged. The current implementation of query expressions can't use arbitrary strings in expressions due to SQL injection problems. Only with the PR to Laravel this feature will be of use. |
tpetry
added a commit
that referenced
this pull request
Jun 9, 2023
Co-authored-by: tpetry <[email protected]>
|
This is now released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @tpetry,
Here is my attempt to add support for string concatenation. It uses concat in all cases except in SQLite, where it uses the corresponding || operator.
I added a test but, honestly, I haven't been able to run the tests so this needs testing before merging.