Skip to content
This repository was archived by the owner on Apr 1, 2023. It is now read-only.

V2 - Implement eject script #193

Merged

Conversation

CarterMcAlister
Copy link
Collaborator

Hi, I took a look at #136 and saw that the eject functionality was one of the outstanding features before the V2 feature is complete.

This PR adds the ability to eject from create-react-library, heavily based on the create-react-app eject logic.

I'm not sure who is the active maintainer of this project so I am tagging @transitive-bullshit @paulmelnikow @wuweiweiwu @danielsogl @sag1v @tsiq-swyx for visibility.

Copy link
Owner

@transitive-bullshit transitive-bullshit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like great work, Carter.

Sent you my feedback re:collaborating over email -- going to merge this for now and take a closer look at everything once v2 is ready to go.

Thanks!!! 🙏

@transitive-bullshit transitive-bullshit merged commit 3ad01c0 into transitive-bullshit:feature/v2 Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants