-
Notifications
You must be signed in to change notification settings - Fork 172
fix: MessageQueueShm head index boundary check #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No unit test because triton-inference-server/server#8273 makes the exploitation impossible. |
yinggeh
commented
Jul 1, 2025
yinggeh
commented
Jul 1, 2025
yinggeh
commented
Jul 1, 2025
yinggeh
commented
Jul 1, 2025
This reverts commit 87f6f2a.
pskiran1
reviewed
Jul 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Will wait for other expert review.
@tanmayv25 can you help approve. |
tanmayv25
approved these changes
Jul 4, 2025
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
When attacker registers the same shm created by python backend, they can overwrite
MessageQueueShm::head
data with a very large index and inject malicious code to the memory space.Checklist
<commit_type>: <Title>
Commit Type:
Related PRs:
Where should the reviewer start?
The index boundary check is in src/message_queue.h
Test plan:
30975011
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)