Improve detection of loop carries in triton frontend #7200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anstow
changed the title
peterbell10
reviewed
Jun 17, 2025
Anstow
commented
Jun 17, 2025
Comment on lines
+439
to
+440
| # We must extract the handles before the value is editted in the loop | ||
| livehandles = {name: flatten_values_to_ir([v]) for name, v in liveins.items() if _is_triton_value(v)} |
There was a problem hiding this comment.
I'm a little worried that I had to do this. I think it's because liveins is not deep-copied from self.local_defs in enter_sub_region. However I ran into other issues when I tried that. My preference is that figuring out that would be done in a different PR. Unless you have any ideas?
|
I don't think the gb200 failure is to do with this PR. I hacked the frontend to produce the IR as if it were compiling for b200 and it is identical before and after my change - but I don't have access to a b200 machine so I can't confirm for certain. I'll update the base branch to see if that improves matters |
Mogball
approved these changes
Jun 23, 2025
|
Thanks for this fix |
peterbell10
added a commit
that referenced
this pull request
Jun 23, 2025
peterbell10
added a commit
that referenced
this pull request
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, loop carries weren't correctly detected when
@builtinor@core.externfunction modified their arguments (which is a particular issue for member functions). This improves the detection of loop carries in for and while loops to handle these cases.New contributor declaration
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsFILL THIS IN.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)