Skip to content

[Backend] Assert that num threads is always power of 2 (NFC) #7251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

Mogball
Copy link
Collaborator

@Mogball Mogball commented Jun 20, 2025

No description provided.

@Mogball Mogball requested a review from ptillet as a code owner June 20, 2025 16:25
@Mogball Mogball requested a review from apgoucher June 20, 2025 16:25
Copy link
Contributor

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough. We were seeing some regressions with code similar like this... weird

@lezcano
Copy link
Contributor

lezcano commented Jun 20, 2025

nvm, after discussing with @apgoucher we believe the regression must have been within noise

@lezcano lezcano merged commit 235496e into main Jun 20, 2025
17 of 18 checks passed
@lezcano lezcano deleted the mogball/assert branch June 20, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants