Case insensitive check between specified requirement and requires_dist #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
suggested changes
Jan 14, 2023
Avasam
commented
Jan 15, 2023
stub_uploader/metadata.py
Outdated
Comment on lines
211
to
212
| if req.name.lower() not in [ | ||
| Requirement(r).name.lower() for r in (data["info"].get("requires_dist") or []) |
There was a problem hiding this comment.
Can I assume that the requirement we manually specify is always a canonical name? Or should I normalize both like this?
Suggested change
| if req.name.lower() not in [ | |
| Requirement(r).name.lower() for r in (data["info"].get("requires_dist") or []) | |
| if canonical_name(req.name) not in [ | |
| canonical_name(Requirement(r).name) for r in (data["info"].get("requires_dist") or []) |
There was a problem hiding this comment.
I guess either we should normalize both or we should test somewhere (probably typeshed) that all reqs are in canonical form.
There was a problem hiding this comment.
Since it was being called twice (thrice with #88). I figured may as well deduplicate it. And now it's only called once anyway, so I feel there's no reason not to use it.
Avasam
commented
Jan 15, 2023
srittau
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #86