Fix/26 filter multimap breaking #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzaeschke
force-pushed
the
fix/26-filter-multimap-breaking
branch
from
6fd05d6 to
853b750
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #26.
Improve the API for
PhTreeMultiMap. The current API expects filters that can filter nodes or entries.The multimap uses collections ("buckets") at each coordinate to store multiple values.
As a result, the current implementation calls the filter once for every entry in every candidate bucket.
This is correct but inefficient.
Many filters will constrain on the coordinate (e.g.
FilterSphere). It would be efficient if such a filter would be called only once per bucket, not once per entry in the bucket.The new API enforces filters with three filter methods:
IsNodeValid(...)filters nodes.IsEntryValid(...)filters buckets. It is called...Entry...because each bucket is an entry in the internalPhTree.IsBucketEntryValid(...)filters entries in buckets.This change breaks the API.