Improve Reporter hasOutput-Check #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There might be a problem of pipelined functions limited by regexp_like in 11g we can probably avoid with a different approach. Additionally, setting a Statement-Timeout here will prevent the cli to wait forever in case of an error.
pesse
changed the title
jgebal
reviewed
Jan 10, 2019
| String sql = "select is_output_reporter from table(ut_runner.get_reporters_list) where regexp_like(reporter_object_name, ?)"; | ||
| String sql = "select is_output_reporter " + | ||
| " from table(ut_runner.get_reporters_list)" + | ||
| " where ? = substr(reporter_object_name, length(reporter_object_name)-?+1)"; | ||
| try ( PreparedStatement stmt = oraConn.prepareStatement(sql)) { |
There was a problem hiding this comment.
It would be much better to have a plsql seperate check for it.
The check could be:
begin
declare
l_result boolean;
begin
execute immediate '
begin
:x :=' || DBMS_ASSERT.SQL_OBJECT_NAME( ? ) || '() is of ut_output_reporter_base;
end;'
using out l_result;
exception when others then null;
end;
? := l_result;
end;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be a problem of pipelined functions limited by regexp_like
in 11g we can probably avoid with a different approach.
Additionally, setting a Statement-Timeout here will prevent the cli to
wait forever in case of an error.