Add autoscaling strategy Invalid conditions #1177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: learner0810 <[email protected]>
learner0810
force-pushed
the
add-valid-autoscaling-strategy-conditions
branch
from
9fd8fb6 to
d1f62df
Compare
googs1025
reviewed
Jun 4, 2025
| return ctrl.Result{}, r.Client.Status().Update(ctx, &pa) | ||
| } | ||
|
|
||
| if apimeta.RemoveStatusCondition(&pa.Status.Conditions, "AutoscalingStrategy") { |
There was a problem hiding this comment.
Why do we want to delete a specific AutoscalingStrategy condition here? 🤔
Jeffwan
reviewed
Jun 11, 2025
| @@ -218,12 +227,6 @@ func (r *PodAutoscalerReconciler) Reconcile(ctx context.Context, req ctrl.Reques | |||
| case autoscalingv1alpha1.KPA, autoscalingv1alpha1.APA: | |||
| return r.reconcileCustomPA(ctx, pa) | |||
| } | |||
|
|
|||
| newStatus := computeStatus(ctx, pa) | |||
There was a problem hiding this comment.
any reason to remove the logic here?
|
@learner0810 hi could you take a look at the comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add error message to PodAutoscaler conditions when PodAutoscaler is using an invalid autoscaling strategy
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.