WIP: [Misc] feature: use kvcache webhook #1187
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
googs1025
force-pushed
the
kvcache_webhook
branch
2 times, most recently
from
50c303c to
ed00058
Compare
| return backend | ||
| } | ||
|
|
||
| // TODO: Move validation logic to webhook. |
There was a problem hiding this comment.
Inspired by this todo
There was a problem hiding this comment.
please make sure --disable-webhook mode can be supported as well. there're some users want to use individual controllers. they want the minimum setup
| default: | ||
| return false | ||
| } | ||
| return kv.Annotations[constants.KVCacheLabelKeyBackend] |
There was a problem hiding this comment.
when we have KVCache webhook, then we can just get from Annotations
googs1025
force-pushed
the
kvcache_webhook
branch
from
ed00058 to
0c24134
Compare
|
TODO: add integration test |
googs1025
force-pushed
the
kvcache_webhook
branch
from
0c24134 to
49ed023
Compare
| @@ -55,7 +55,7 @@ var _ = Describe("KVCache Controller", func() { | |||
| ObjectMeta: metav1.ObjectMeta{ | |||
| Name: resourceName, | |||
| Namespace: "default", | |||
| Labels: map[string]string{ | |||
There was a problem hiding this comment.
I think this is a typo? 🤔
There was a problem hiding this comment.
oh. I see, you mean labels -> annotations?
could you double check the examples?
There was a problem hiding this comment.
I have checked the current examples, all of them are annotations 😄
There was a problem hiding this comment.
Got you. yeah, then it mush be typo introduced in the initial PR. luckily, that's the test file so I think we didn't notice the issue
googs1025
force-pushed
the
kvcache_webhook
branch
2 times, most recently
from
4467ef5 to
61cb366
Compare
Signed-off-by: googs1025 <[email protected]>
googs1025
force-pushed
the
kvcache_webhook
branch
from
61cb366 to
a51508a
Compare
|
part of #710 |
|
will add some integration test this week |
Pull Request Description
[Please provide a clear and concise description of your changes here]
Related Issues
Resolves: #[Insert issue number(s)]
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.