Skip to content

added doneCallback to track completion of async operation #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

greatramu
Copy link

Added doneCallback after the cancelCallback to help user track the completion of async operations.

Added ```doneCallback``` after the ```cancelCallback``` to help user track the completion of async operations.
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request head (patch-1@d274b79).


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58c4ae1...d274b79. Read the comment docs.

@jwngr
Copy link

jwngr commented Jan 31, 2017

Thanks for the PR! What are you trying to accomplish with this API? As is, the doneCallback() you provide is going to be called a bunch of times and I don't think it will really do what you want it to. Are you maybe trying to figure out when the initial data has loaded? If so, I would suggest checking out this Stack Overflow post.

@posva
Copy link
Member

posva commented Jan 31, 2017

Hey @greatramu thanks a lot for the PR. As @jwngr pointed out, this is not the right way to go.
I have plans to add this feature as it makes SSR easier. I still want to do some testing though
I'll open an issue so you can subscribe to it and keep track of it 😉

@posva posva closed this Jan 31, 2017
posva added a commit that referenced this pull request Jul 10, 2018
Closes #68

Signed-off-by: Eduardo San Martin Morote <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants