[feat] Add asyncData Method Type to ComponentOptions Module Augmentation #1214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use Vue SSR heavily at @algorithmiaio, and we've followed the Vue SSR-sanctioned means of declaring async data methods. We've shimmed together our own module augmentation for the
asyncData
method, but given the prevalence ofasyncData
usage throughout the Vue community, it would be nice to standardize the interface.I was torn as per where this should live - there isn't a repo for SSR, given that it lives in the Vue repo, and ultimately it felt right here with the Vuex project, since
asyncData
and Vuex go hand in hand.I've added a test for the new type as well, and let me know if there's anything I can tweak. Cheers!