Skip to content

[Feature request] Improve shouldPrefetch and shouldPrefetch option #952

Open
@Mister-Hope

Description

@Mister-Hope

Clear and concise description of the problem

Currenly the (file: string, type: string) => boolean is TOO unmeaningful.

The file args in vite is the output chunk name, which is probably like index.html.xxxx.js.

image

It lost infoamtion about how it was generated, so users at this time have No idea about what's page is this chunk generated from. So it's impossible for a developer or a user to take actual effect when setting a function.

Just an example, I am getting hundreds of index.html.xxxx.js in https://github.com/vuepress-theme-hope/v2/tree/gh-pages/assets.

image

Suggested solution

The parameters should be rebuilt. At least it should include:

  • chunk filename

  • chunk filetype (can be ommited if filename contains extension). Also I am confused why current api seperate a full chunk path into file name and file type.

  • chunk infomation about how this chunk is generated.

    Could be things like:

{from: 'markdown', source: 'path/to/markdown.md'}
{from:'import', source: 'path/to/files/where/the/chunk/is/imported.ts'}
{from:'script', source: 'path/to/file/entry.ts'}

Edited: In some cases we might get an array here, so we can use array formats.

Alternative

No response

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions